fdarmon / NeuralWarp

Code release of paper Improving neural implicit surfaces geometry with patch warping
234 stars 14 forks source link

Is Patch Warping enabled in current Codebase ? #2

Closed anuveshkumaratavataar closed 2 years ago

anuveshkumaratavataar commented 2 years ago

Hi, Thanks for the excellent paper.

I was going through the code base and the warping seems to happen only for random pixels sampled on the image plane (viz. clipped off at boundaries), and not patches. line 155-166 in https://github.com/fdarmon/NeuralWarp/blob/main/datasets/scene_dataset.py

Is it right, or am I missing something ?

fdarmon commented 2 years ago

Hi, thanks for the question.

In the lines of code you mention, we indeed pick random pixels in the image (cliped off at boundaries). But we use the patch located around these pixels, see in the loss computation for example https://github.com/fdarmon/NeuralWarp/blob/main/training/loss.py#L90

I hope this helps, François