Added support for BodyDevInfo = 2 in CFG file

fdbozzo / foxbin2prg

Visual FoxPro 9 Binary to Text and Text to Binary converter. Replacement for SCCText(X) and TwoFox that is bi-directional (Text is editable)

https://vfpx.codeplex.com/wikipage?title=FoxBin2Prg

MIT License

59 stars 35 forks source link

Added support for BodyDevInfo = 2 in CFG file #109

Closed DougHennig closed 2 months ago

DougHennig commented 2 months ago

v1.21.04: Added support for BodyDevInfo = 2 in CFG file to prevent both DevInfo and ObjRev from being written to PJ2 file

lscheffler commented 2 months ago

Hi @DougHennig,

Great!

I have no idea what those two fields are good for. So I trust that it makes sense to clean them together and that there is no need to clean ObjRev only. Otherwise I would recommend a single (On/Off) setting special for ObjRev.

According to CONTRIBUTING, would you mind to alter, :

Version number on top of Create_FoxBin2Prg.cfg (I need to update this in the contrib file)
README.md
docs\ChangeLog.md
docs\FoxBin2Prg_Internals.md
- the table at Configuration file is missing BodyDevInfo at all. Would you be so kind to add it, and give a little hint what it is good for? It should be enough inside this table.

Thank you!

DougHennig commented 2 months ago

@lscheffler Done.

lscheffler commented 2 months ago

So far. Except, when you follow https://github.com/fdbozzo/foxbin2prg/pull/109/commits/8384b6c100e0c14f76b3ba83195d43b9c3b7dc8f ;

grafik

this is the diff you see above as, you see that all the md files are changed as a whole. Your editor has altered CRLF to LF. Please use something that keeps the line endings. (My guess: not the github UI, it does not look like your git is the culprit, since the prg is fine)

lscheffler commented 2 months ago

@Doug I can do this, but not via the GH interface, because this would force me to merge to master branch, and then the change is published. I would get your change to my local repo, alter, merge and push in my name. This means, your visible contribution is lost to GH, but still valid in FoxBin2Prg and it's git history.

DougHennig commented 2 months ago

I used Markdown Monster, which was configured for LF. I've changed that to CRLF and updated the MD files.

lscheffler commented 2 months ago

I know I'm a pain. But contribution, New version:

Please alter the footer of *.md files touched to recent date.

off topic

Is markdown able to just keep line endings? If not, one should talk to Rick ...

DougHennig commented 2 months ago

Sorry, I missed that. Done.

According to the docs, Markdown Monster is supposed to keep existing line endings but appears to change them to the selected ones. I have it configured to use CRLF now.