fdcl-gwu / aruco-markers

Working examples/tutorial for detection and pose estimation of ArUco markers with C++, including instructions to build and install OpenCV from source.
BSD 3-Clause "New" or "Revised" License
239 stars 71 forks source link

Calibration tool arguments #2

Closed saratrajput closed 5 years ago

saratrajput commented 5 years ago

In the camera_calibration code, the marker side length and separation between two separate markers is mentioned in meters. So, this should be measured when you print the board. Thus in README, the steps should be changed from: ./camera_calibration -d=16 -dp=../detector_params.yml -h=2 -w=4 -l=200 -s=100 ../../calibration_params.yml

TO

./camera_calibration -d=16 -dp=../detector_params.yml -h=2 -w=4 -l=\<measured length in meters> -s=\<measured length in meters> ../../calibration_params.yml

kanishkegb commented 5 years ago

Thank you for pointing this out. Yes, you are correct. I guess I copied and pasted the arguments from the marker generation commands, and forgot to change that.

Issue corrected in e9b1454.