PartialOrd and Ord for `Timestamp`

fdeantoni / prost-wkt

Prost Well-Known-Types serialization and deserialization.

Apache License 2.0

76 stars 35 forks source link

PartialOrd and Ord for `Timestamp` #15

Open bjchambers opened 2 years ago

bjchambers commented 2 years ago

It seems like Timestamp could (and perhaps should) implement PartialOrd and Ord. This should be pretty straightforward given the constraints -- compare the seconds, and if equal compare the nanos. Any reason these shouldn't be added?

fdeantoni commented 1 year ago

This project simply takes implementations of Timestamp from Prost-types, so I'm hesitant to define it here. Perhaps it should be raised as an issue in the tokio-rs/prost project instead?