search

fdeantoni / prost-wkt

Prost Well-Known-Types serialization and deserialization.
Apache License 2.0
76 stars 35 forks source link

added implementations for Duration to chrono #35

Closed alexthe2 closed 1 year ago

alexthe2 commented 1 year ago

Added chrono::Duration <-> pbDuration

alexthe2 commented 1 year ago

@fdeantoni forgot to tag you

fdeantoni commented 1 year ago

Thanks for this PR @alexthe2! The PR generally looks good but I see it also includes .idea files. Are these necessary or can we just make do with the changes in src/pbtime.rs?

alexthe2 commented 1 year ago

Oh yeah, ofc I guess the .gitignore didn't work correctly, let me fix that

alexthe2 commented 1 year ago

done ;)

fdeantoni commented 1 year ago

Thanks @alexthe2! One thing though, I would rather not include any IDE specific things in the project .gitignore. I think those are better placed in your global gitignore (since you can tailor that one specifically to the IDE you use). I know it's a little pedantic, but I hope it makes sense :) After all, there are many different IDE's out there and the working files/folders they store may change over time...

alexthe2 commented 1 year ago

sorry, for the long wait I forgot about it. Modified it

fdeantoni commented 1 year ago

This is great, many thanks @alexthe2 !