added option to normalize histogram plot

fdebrain / streamlit-vega-lite-charts

A streamlit web app to generate insightful charts from tabular data.

https://vega-lite-charts.streamlitapp.com/

MIT License

4 stars 5 forks source link

added option to normalize histogram plot #13

Closed all4one-max closed 2 years ago

all4one-max commented 2 years ago

Normalize button works well with X, but doesn't respond to ordinal values
Normalize button does not work with stacked and layered histogram, necessary warnings have been added

fdebrain commented 2 years ago

@all4one-max Thanks for the work, there are a few bugs that I would like to fix before merging. Here is a summary:

Make the normalized histogram responsive to the bins slider
X-axis labels & ticks should adapt to the bins slider as well
Make it possible to have a normalized and ordinal histogram
Fix the transform such that percentages add up to 100% (probably due to null values)

I can help with some of these if needed.

I'll open a separate issue to extend the normalization to stacked and layered histograms.

all4one-max commented 2 years ago

@fdebrain Hey! I tried managing the ordinal and normalize together but there's not much content available on the internet to work this out. I would request you merge with the current set of changes. If not possible then you may close the issue and assign me the heatmap one, I'll try that.

fdebrain commented 2 years ago

@fdebrain Hey! I tried managing the ordinal and normalize together but there's not much content available on the internet to work this out. I would request you merge with the current set of changes. If not possible then you may close the issue and assign me the heatmap one, I'll try that.

@all4one-max Thanks for your help! I'll give it a try and if I don't find a solution this weekend, I'll just merge and create a new issue.

fdebrain commented 2 years ago

What is done:

Implementation of basic normalization with responsive binning
Ignoring NaNs when normalizing
Warning messages for not yet implemented features regarding histogram normalization.

What is to be done: (will open a separate)

X-axis labels & ticks should adapt to the bins slider as well
Make it possible to have a normalized and ordinal histogram
Extend normalization to stacked and layered histograms