search

fdebrain / streamlit-vega-lite-charts

A streamlit web app to generate insightful charts from tabular data.
https://vega-lite-charts.streamlitapp.com/
MIT License
4 stars 5 forks source link

adds line chart #9

Closed utopian-monkey closed 2 years ago

utopian-monkey commented 2 years ago

added the basic line chart with category colour feature

fdebrain commented 2 years ago

Thanks for the work @utopian-monkey. Could you do a git merge main to include a fix I did on the CI checks? Also, a good coding practice would be to use pre-commits locally (pre-commit run -a) to make sure we use the same coding standards.

I'll do a full code review asap

fdebrain commented 2 years ago

Axis labels look a bit confusing. Maybe you could add "type": "quantitative" to both x and y axis?

Screenshot from 2022-10-11 14-51-31

utopian-monkey commented 2 years ago

sure, will do these changes asap

fdebrain commented 2 years ago

sure, will do these changes asap

Thanks a lot! I just added a line in my .github/workflows/main.yml, I think it should activate the Github Actions in here too if you add it.

utopian-monkey commented 2 years ago

please check, ive updated

utopian-monkey commented 2 years ago

any updates?

fdebrain commented 2 years ago

any updates?

Could you update the code with the suggested changes above?

utopian-monkey commented 2 years ago

i have already, please check this commit