fdefelici / vs-funreal

Visual Studio extension to smooth the workflow of Unreal Engine C++ developers
MIT License
27 stars 7 forks source link

Unable to detect UE version from .uproject file on custom UE build #1

Closed mklierman closed 1 year ago

mklierman commented 1 year ago

I get the error Cannot detect UE version from .uproject file when loading my project.

In my .uproject file the EngineAssociation field has the value "4.26.2-ABC". It looks like your code assumes the version field will only be 2 parts, in which case even using the standard 4.26.2 engine version would fail: XVersion.cs

Perhaps that code could be updated to only read the first 2 parts of the SemVer and ignore the rest?

fdefelici commented 1 year ago

Hi @mklierman, thanks for reporting the issue.

During development, I play tested with 4.27.2, 5.0.3 and 5.1 and I always had the pattern MAJOR.MINOR in the .uproject (patch number was never present). So I worked with this assumption.

Anyway I can take into account the custom version pattern as you propose, and make the version parsing less "restrictive".

create-issue-branch[bot] commented 1 year ago

Branch issue-1-Unable_to_detect_UE_version_from_uproject_file_on_custom_UE_build created!

fdefelici commented 1 year ago

Now can recognize the following semver pattern: MAJOR.MINOR.PATCH-LABEL where:

fdefelici commented 1 year ago

@mklierman FUnreal v0.0.5 is out and should address your issue

mklierman commented 1 year ago

Thanks. I can confirm it worked