Alarm trigger

[fdegier]

Support for triggered alarm. I have tested it an come to the following observations. I have setup a spare Jablotron central, it has no modules connected and the lid is off, therefore it is continuous tamper alert. I have added both alarm and tamper as states for a triggered alarm.

The good:

• It gives a notification if the alarm is triggered
• It shows the alarm is triggered
• Its a trigger per section

The bad:

• Once homebridge starts up, the state does not go to triggered after 60 seconds it does trigger the triggered alarm
• After initial start up, it randomly notifies that the alarm is triggered (note this alarm is always triggered)

My thoughts and ask for help:

• I think the initial startup skips the triggering part, however I can not find it in the code
• The background update, it should run every 60 seconds but it does not seem to trigger ever 60 seconds.

@misncz @grzegorz914 can you check the code and chime in on the issues described above?

I can share the Jablotron service so you can play around with it.

[fdegier]

[fdegier]

Closes #40

[fdegier]

@grzegorz914 and @misncz can you please check my PR?

[misncz]

There will be conflicts with thermometer changes

[fdegier]

@misncz I have resolved the merge conflicts. Since there is now a third value in the callback which for a triggered alarm is not available, I have just added an empty string. Is this OK? Do you mind checking the merge result, especially in jablotron.js?

[misncz]

Will have a look in the morning. Instead of empty string pass null ( For thermomemters it’s an array of information objects)

[misncz]

jablotron.js changes broke thermometer and PGM (sirene or switch). Need to have a look

[misncz]

Change to parseResponseData method broke getAccessoryStates method that now loop only through first data type (ie sections) and ignores PGM & thermometers - it's something I'm able to fix Also getAccessorState looks suspicious to me as it calls callback with 'triggered' but doesn't check accessory key. Also call to callback needs 2 params callback('triggered', null)

[misncz]

@fdegier I pushed a fix getAccessoryStates and tried to modify getAccessoryState the same way as getAccessoryStates. Now it should be fine. Please test alarm triggering now

[fdegier]

Thank you, good improvements!

I've tested it but now it gives an error that I fixed earlier:

[2/27/2022, 10:58:41 AM] [homebridge-jablotron] This plugin generated a warning from the characteristic 'Security System Target State': characteristic was supplied illegal value: number 4 exceeded maximum of 3. See https://git.io/JtMGR for more info.

This happens because it tries to set the target state to triggered which isn't a target state, only a current state. I'm investigating the exact cause now.

[fdegier]

This part is the cause for the warning:

if (fullReport && state != this.getTriggeredStateMapping()) {
                     this.updateServiceCharacteristic(Characteristic.SecuritySystemTargetState, state);
                 }

So state is probably incorrect.

[fdegier]

I have done some debugging but I couldn't find the culprit. I do notice:

1. The triggered "state" seems instant now
2. Notifications no longer work

@misncz shall I give you access to the Jablotron that is always triggered so you can debug the issue?

[MartinKristof]

Could be merged please?

[MikeFParkin]

Does the alarm triggering still not work? ☹️ Will this issue ever be fixed/merged?

[fdegier]

It will, eventually. It was ready to be merged but there is now a conflict that breaks the functionality. Besides that we need to upgrade the API version which has a higher priority and will break more things.

[MikeFParkin]

It will, eventually. It was ready to be merged but there is now a conflict that breaks the functionality. Besides that we need to upgrade the API version which has a higher priority and will break more things.

No problem, thanks for the update - and for all the hard work you, and the team, put into making this plugin a reality!

[fdegier]

Closing this PR as the functionality will be picked up in a new PR that is on par with the new API version.