fdegier / homebridge-jablotron-alarm

Homebridge plugin for connecting Jablotron JA-100 alarm systems to Homekit.
The Unlicense
26 stars 5 forks source link

Poll interval value for 'Auto Refresh' option is ignored #85

Closed jasonhnz closed 2 years ago

jasonhnz commented 2 years ago

Describe The Problem: In Settings, Advanced options, when the Auto Refresh option is selected, the poll interval value appears to be ignored. I have entered a value of 21600 (6 hours) however the module still appears to be polling every minute. (as shown in the logs)

Using a GSM module , this polling is using up data allocation quickly.

To Reproduce: As above, go into advanced options, select Auto Refresh and set an interval val > 1 minute. Save and restart homebridge to pick up changes and watch logs for this service.

Logs: Sample logs

[10/5/2022, 10:45:37 PM] [Jablotron] Status refreshed for Jablotron service XXXXX [10/5/2022, 10:46:35 PM] [Jablotron] Refreshing status for Jablotron service XXXXX [10/5/2022, 10:46:37 PM] [Jablotron] Accessory state for segment section_1 = unset [10/5/2022, 10:46:37 PM] [Jablotron] About to update state for accessory [section_1] : update = false; cachedState = 3; newState = 3 [10/5/2022, 10:46:37 PM] [Jablotron] Accessory state for segment pgm_1 = unset [10/5/2022, 10:46:37 PM] [Jablotron] About to update state for accessory [pgm_1] : update = false; cachedState = false; newState = false [10/5/2022, 10:46:37 PM] [Jablotron] Accessory state for segment pgm_2 = unset [10/5/2022, 10:46:37 PM] [Jablotron] About to update state for accessory [pgm_2] : update = false; cachedState = false; newState = false [10/5/2022, 10:46:37 PM] [Jablotron] Status refreshed for Jablotron service XXXXX [10/5/2022, 10:47:35 PM] [Jablotron] Refreshing status for Jablotron service XXXXX [10/5/2022, 10:47:37 PM] [Jablotron] Accessory state for segment section_1 = unset [10/5/2022, 10:47:37 PM] [Jablotron] About to update state for accessory [section_1] : update = false; cachedState = 3; newState = 3 [10/5/2022, 10:47:37 PM] [Jablotron] Accessory state for segment pgm_1 = unset [10/5/2022, 10:47:37 PM] [Jablotron] About to update state for accessory [pgm_1] : update = false; cachedState = false; newState = false

Show the Homebridge logs here.
Remove any sensitive information.

Environment:

misncz commented 2 years ago

@jasonhnz yes there's a bug that doesn't update configuration properly via plugin Settings. However you can workaround this bug - instead of going to plugin Settings go to Config on homebridge screen - this opens raw config file where you can change pollInterval to whatever value you need. Once you restart plugin/homebridge it picks up this value. Meanwhile I'm going to provide a simple fix to plugin Settings to update correct value

"autoRefresh": true, "pollInterval": 180,

misncz commented 2 years ago

@jasonhnz @fdegier raised pull request for the fix ... https://github.com/fdegier/homebridge-jablotron-alarm/pull/86

fdegier commented 2 years ago

Fixed in https://github.com/fdegier/homebridge-jablotron-alarm/releases/tag/v2.5.6 thanks!

jasonhnz commented 2 years ago

Thanks! Will update today.