fdemmer / django-weasyprint

A Django class-based view generating PDF resposes using WeasyPrint
Other
352 stars 53 forks source link

Add minimal tests #28

Closed ziima closed 4 years ago

ziima commented 5 years ago

I've tried to add minimal tests. I've read #22 and I tried to add as minimal code as possible.

Let me know if you request further changes.

ziima commented 5 years ago

I'd like to make more changes, but I just don't feel comfortable with no tests around.

fdemmer commented 5 years ago

Thank you for your contribution(s)!

Is this finished? How do you run the test?

ziima commented 5 years ago

This part is. Currently, the tests may be run by

DJANGO_SETTINGS_MODULE=django_weasyprint.tests.settings  python -m django test django_weasyprint

but I'd recommend to add tox later on. I'd leave that for another issue.

fdemmer commented 4 years ago

included with further work in 69be0583ab2244d221e7fbf32e654fb47ecb4821