Add support for relative url paths when not serving from /

fdesjardins / coverage-viewer

A cross-platform code coverage report generator

MIT License

16 stars 4 forks source link

Add support for relative url paths when not serving from / #4

Closed coderpatros closed 6 years ago

coderpatros commented 6 years ago

This is for when index.html is being served from a path besides / so that the "All files" link works from the generated file pages

fdesjardins commented 6 years ago

This looks good, but I'm seeing undefined for the "All Files" URL on the SummaryPage. Maybe we can just pass indexPath: '' to Layout in SummaryPage.js?

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 23

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 28.09%

Totals
Change from base Build 22:	0.4%
Covered Lines:	50
Relevant Lines:	152

💛 - Coveralls

coderpatros commented 6 years ago

Good pick up. I've rebased this off v0.1.1 and done as you suggested.

fdesjardins commented 6 years ago

Nice, looks good to me. :+1: Thanks for the updates!

coderpatros commented 6 years ago

You're welcome, thanks for making such a great tool.