search

fdetsch / MODIS

Download and processing framework for MODIS imagery. The package provides automated access to the global online data archives LP DAAC, LAADS and NSIDC as well as processing capabilities such as file conversion, mosaicking, subsetting and time series.
Other
58 stars 27 forks source link

Gracefully failing internet resources #132

Closed fdetsch closed 1 year ago

fdetsch commented 1 year ago

As per CRAN team,

'Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).'

The failures were

----- FAILED[xcpt]: test-EarthdataLogin.R<151--156>
call| expect_warning(out2.0 <- MODIS:::checkEarthdataLogin(path = nrc),
call| --> pattern = "Authentication failed with\n> HTTP error
(401|504)")
diff| No warning was emitted
----- FAILED[data]: test-EarthdataLogin.R<158--160>
call| expect_false(out2.0)
diff| Expected FALSE, got TRUE
fdetsch commented 1 year ago

See also discussion on the EARTHDATA Forum.