search

fdev1 / ssmtp-reloaded

Fork of ssmtp with some additional features and bug fixes.
GNU General Public License v2.0
3 stars 2 forks source link

AuthPass config item not being handled correctly #4

Open clmcavaney opened 8 years ago

clmcavaney commented 8 years ago

I am finding that the password is retaining the return character (i.e. \n) from the config file. I believe the fault is on lines 1439 to 1444 of ssmtp.c ([https://github.com/fernando-rodriguez/ssmtp-reloaded/blob/master/ssmtp.c#L1439-L1444]) The should be before the strdup() call or the strdup() should be of the value pointer (i.e. 'q') and not the rightside.

fdev1 commented 8 years ago

On 04/21/2016 11:21 PM, Christopher McAvaney wrote:

I am finding that the password is retaining the return character (i.e. \n) from the config file. I believe the fault is on lines 1439 to 1444 of ssmtp.c ([https://github.com/fernando-rodriguez/ssmtp-reloaded/blob/master/ssmtp.c#L1439-L1444]) The should be before the strdup() call or the strdup() should be of the value pointer (i.e. 'q') and not the rightside.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/fernando-rodriguez/ssmtp-reloaded/issues/4

You're right, there's something wrong there, I'm not sure why it works for some. Thanks for the report. Check back tomorrow and I'll have a fix.

fdev1 commented 8 years ago

Commit 9bfaf057 (staging branch) should fix it. I just need to do more testing before merging it.