fdietz / elixir-feed-parser

Elixir Feed Parser
Other
49 stars 18 forks source link

Return NIL instead of ERROR for unparsed date string #8

Closed andyl closed 5 years ago

andyl commented 5 years ago

I've used elixir-feed-parser on a couple-dozen RSS feeds, and I've only seen it fail on http://elixirstatus.com/rss. I believe that ElixirStatus uses some sort of German time format that isn't parsed properly by Timex.parse.

On parse-failure, instead of raising an error, this change returns NIL, and logs a warning message. This is a good behavior because IMO many or most aggregators ignore the feed dates anyway.

THANKS for elixir-feed-parser it is super-useful. :-)

fdietz commented 5 years ago

Thank you!