Play 2.7 released - Githubissues

fdimuccio / play2-sockjs

A SockJS server implementation for Play Framework.

Apache License 2.0

62 stars 11 forks source link

Closed Flo354 closed 5 years ago

Flo354 commented 5 years ago

Hi there :)

Play 2.7 is now stable (version 2.7.0). Will you update the module?

Thanks,

Flo354 commented 5 years ago

In mode "quick & dirty", I made two modifications to make it work again temporary:

=> In JavaRouter.scala protected def materializer: Materializer = play.api.Play.unsafeApplication.materializer

=> In CookieFunctions return new Http.Cookie("JSESSIONID", value, null, "/", null, false, false, Http.Cookie.SameSite.STRICT);

I don't think it's the good way, since Play team recommends using dependency injection since play.allowGlobalApplication is now "false" by default.

mellster2012 commented 5 years ago

For play scala the above fix for CookieFunctions seems sufficient to make sockjs work with play 2.7.0

mellster2012 commented 5 years ago

Refactored for DI.

fdimuccio commented 5 years ago

I merged the PR and released 0.7.0.

Thank you for your effort.