search

fdintino / pillow-avif-plugin

A pillow plugin that adds avif support via libavif
BSD 2-Clause "Simplified" License
90 stars 13 forks source link

Python 3.11 (currently rc2) support #17

Closed S1SYPHOS closed 2 years ago

S1SYPHOS commented 2 years ago

Hey there, when building its wheels using Python 3.11 (installed via pyenv), I get this:

gcc -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/home/path/to/my/project/.tox/py311/include -I/home/two-brain/.pyenv/versions/3.11.0rc2/include/python3.11 -c src/pillow_avif/_avif.c -o build/temp.linux-x86_64-cpython-311/src/pillow_avif/_avif.o
      src/pillow_avif/_avif.c:4:10: fatal error: avif/avif.h: No such file or directory
          4 | #include "avif/avif.h"
            |          ^~~~~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]

All other python versions succeed just fine. Thanks so much for this package anyway! :+1:

fdintino commented 2 years ago

That would be because the other versions of python have manylinux wheels hosted on PyPI. If you wanted to build it yourself you would need to install the build dependencies for libavif (e.g. on debian or ubuntu, this script) and then build and install libavif (see install_libavif.sh). But I wouldn't recommend going to the trouble...I'll add python 3.11 to the build matrix and push up the wheels to PyPI.

S1SYPHOS commented 2 years ago

Thanks for your thorough and quick reply!

fdintino commented 2 years ago

I've just uploaded python 3.11 wheels to PyPI. Could you try it out and see if it's working now for you?

S1SYPHOS commented 2 years ago

@fdintino .. working as expected now, thank you very much!