Closed fdionisi closed 5 years ago
@pranaygp I had a look at the PR and found the potential issue: animationFrameLoop was being called recursively.
animationFrameLoop
I moved it to TextEditor.handleMouseMove where I exit from it early when this.state.mouseDown is false, avoid calling window.requestAnimationFrame.
TextEditor.handleMouseMove
this.state.mouseDown
false
window.requestAnimationFrame
It has been a long time, but if you have a chance to ensure my changes are not breaking something else that I'm not seeing it would be amazing.
Original PR: atom#107
@pranaygp I had a look at the PR and found the potential issue:
animationFrameLoopwas being called recursively.I moved it to
TextEditor.handleMouseMovewhere I exit from it early whenthis.state.mouseDownisfalse, avoid callingwindow.requestAnimationFrame.It has been a long time, but if you have a chance to ensure my changes are not breaking something else that I'm not seeing it would be amazing.
Original PR: atom#107