fdionisi / xray

An experimental next-generation Electron-based text editor
MIT License
47 stars 0 forks source link

Hourann/fix panic at index out of bound #4

Closed fdionisi closed 5 years ago

fdionisi commented 5 years ago

@flappyBug sorry bothering you, but you think the test I added would be enough? Also, you find the test name could fit?

Thanks and sorry again 😬

Original PR: atom#172

flappyBug commented 5 years ago

I'm busy these days. Sorry for my late reply though.

It’s been a long time since I made this PR and I can't remember many details. I think you should be more confident than me on this PR. And thank you for adding a test case. It looks fine as I just glance at it. Just check that the test case fails before we make this change and passes after we change it.

Thank you again for trying to keep xray alive. It's an awesome project. I'm willing to contribute when I have more time.