search

fdmsantos / terraform-aws-kinesis-firehose

Dynamic Terraform module, which creates a Kinesis Firehose Stream and others resources like Cloudwatch, IAM Roles and Security Groups that integrate with Kinesis Firehose. Supports all destinations and all Kinesis Firehose Features.
https://registry.terraform.io/modules/fdmsantos/kinesis-firehose/aws/latest
Apache License 2.0
11 stars 8 forks source link

Do not require enable_dynamic_partitioning for dynamic_partition_append_delimiter_to_record #13

Closed Tonkonozhenko closed 8 months ago

fdmsantos commented 8 months ago

Thanks for this PR. It seems now is possible adding new line delimiter without dynamic partitioning. I think that wasn't possible.

fdmsantos commented 8 months ago

I have deprecated dynamic_partition_append_delimiter_to_record because i think is not makes sense anymore having the prefix "dynamic_partition". The new variable is append_delimiter_to_record .

The Old variable will be removed on next Major Version (4.0.0).

This PR will be released on version 3.3.0.

fdmsantos commented 8 months ago

Thanks @Tonkonozhenko

fdmsantos commented 8 months ago

This PR is included in version 3.3.0 :tada:

Tonkonozhenko commented 8 months ago

thank you @fdmsantos !