fdmsantos / terraform-aws-kinesis-firehose

Dynamic Terraform module, which creates a Kinesis Firehose Stream and others resources like Cloudwatch, IAM Roles and Security Groups that integrate with Kinesis Firehose. Supports all destinations and all Kinesis Firehose Features.
https://registry.terraform.io/modules/fdmsantos/kinesis-firehose/aws/latest
Apache License 2.0
11 stars 8 forks source link

Fix configuring existing role bug #3

Closed schshmuel closed 1 year ago

schshmuel commented 1 year ago

Using the following setup didn't work (Same as one of the examples).

Configure existing Application Role to an application that runs in EC2 Instance with a policy with provided actions


module "firehose" {
source = "fdmsantos/kinesis-firehose/aws"
version = "x.x.x"
name = "firehose-delivery-stream"
destination = "s3" # or destination = "extended_s3"
configure_existing_application_role = true
application_role_name = "application-role"
create_application_role_policy = true
application_role_policy_actions = [
"firehose:PutRecord",
"firehose:PutRecordBatch",
"firehose:CreateDeliveryStream",
"firehose:UpdateDestination"
]
}

I got an error name = "${local.application_role_name}-policy" is null.

fdmsantos commented 1 year ago

This PR is included in version 2.1.1 :tada:

fdmsantos commented 1 year ago

Thanks @schshmuel