search

fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
58 stars 33 forks source link

fix(spec): add both clients as fdo-admin-cli's Requires #541

Closed 7flying closed 1 year ago

7flying commented 1 year ago

We removed the clients from the Requires list so the fdo-aio.service can't start. This fixes that.

Fixes rhbz#2230537

nullr0ute commented 1 year ago

Why does the FDO AIO require the clients, it's server side there shouldn't be a dep here?

7flying commented 1 year ago

Why does the FDO AIO require the clients, it's server side there shouldn't be a dep here?

@nullr0ute because the aio tool also has the ability to generate device credentials and start the onboarding, it has the client-linuxapp and the manufacturing-client as dependencies in the code. (I haven't ever used these options)

$ fdo-admin-tool aio device --help
Usage: fdo-admin-tool aio device --device-credential-location <DEVICE_CREDENTIAL_LOCATION> <COMMAND>

Commands:
  manufacture  
  analyze      
  run          
  help         Print this message or the help of the given subcommand(s)

Options:
      --device-credential-location <DEVICE_CREDENTIAL_LOCATION>  
  -h, --help                                                     Print help
  -V, --version                                                  Print version
runcom commented 1 year ago

lgtm - @nullr0ute please take another look