search

fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
62 stars 34 forks source link

chore: fixup paths for selinux #547

Closed runcom closed 1 year ago

runcom commented 1 year ago

Using the service-info-api server with selinux requires us to put anything we want to send to the device under /var/lib/fdo as that directory, and its files, will now get the correct selinux label. The previous approach opens up for security issues by leaving the process basically accessing the whole host.

7flying commented 1 year ago

Can you also update the example on https://github.com/fedora-iot/fido-device-onboard-rs/blob/main/HOWTO.md?plain=1#L448-L454 and add a comment on https://github.com/fedora-iot/fido-device-onboard-rs/blob/main/HOWTO.md?plain=1#L493-L494 ?

runcom commented 1 year ago

fixed, should be good now

7flying commented 1 year ago

You can cherry-pick the commit from #548 (or we can merge and rebase) to make the clippy test pass

runcom commented 1 year ago

You can cherry-pick the commit from #548 (or we can merge and rebase) to make the clippy test pass

done