search

fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
58 stars 32 forks source link

Replace the `users` crate with `sysinfo` #566

Closed 7flying closed 9 months ago

7flying commented 10 months ago

The users crate that we currently use in our integration tests is unmaintained and security patches are not being applied. Ditch that crate in favour of sysinfo.

There is a direct fork of users called uzers, but that crate is not packaged in Fedora, and sysinfo is, so the change seems easier this way.

miabbott commented 10 months ago

FWIW, the CoreOS folks are using uzers in their projects - https://github.com/search?q=org%3Acoreos%20uzers&type=code

Not sure how they are handling the lack of a Fedora package (probably vendoring?), but wanted to mention it.

nullr0ute commented 10 months ago

They are vendoring, we can add extra packages, we just need to be cognizant of the extra work, I would sooner go to something that had a healthy upstream and have to package it rather than move to something that doesn't and have other issues.

miabbott commented 10 months ago

...I would sooner go to something that had a healthy upstream...

Based on the "Insights" from GH on uzers and sysinfo, it does look like sysinfo is more active...so feels like it is the better choice on that metric.