fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
58 stars 32 forks source link

Automatic merge-queue / mergify not working anymore #571

Closed 7flying closed 10 months ago

7flying commented 10 months ago

After a PR is reviewed and approved mergify used to take care of the merge automatically, but it no longer does, and it shows the following warning:

Branch protection settings are not validated anymore Branch protection is enabled and is preventing Mergify to merge the pull request. Mergify will merge when branch protection settings validate the pull request once again. (detail: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.)

it looks like we should disable branch protection.

7flying commented 10 months ago

See https://github.com/fdo-rs/fido-device-onboard-rs/pull/570 as an example

nullr0ute commented 10 months ago

it looks like we should disable branch protection.

Entirely possible, I think that's enabled by default in the new org, go for it.

7flying commented 10 months ago

Merfigy needed to be given push access, I haven't modified the branch protection rules, so all good :+1: