search

fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
58 stars 32 forks source link

chore: bump tss-esapi crate to 7.4 #608

Closed nullr0ute closed 7 months ago

nullr0ute commented 7 months ago

There's a few minor fixes and no changes in API so let's bump to 7.4 for TPM2 support.

7flying commented 7 months ago

I don't understand why this breaks the rust-aws-nitro-enclaves-cose too

nullr0ute commented 7 months ago

I don't understand why this breaks the rust-aws-nitro-enclaves-cose too

I think the breakage is the known issue we already have with rust-aws-nitro-enclaves-cose where we patched it in Fedora.

7flying commented 7 months ago

I don't understand why this breaks the rust-aws-nitro-enclaves-cose too

I think the breakage is the known issue we already have with rust-aws-nitro-enclaves-cose where we patched it in Fedora.

yes, but it wasn't showing up upstream before, I need to take a look to check how we can avoid this upstream too, otherwise our tests and builds are all broken

nullr0ute commented 7 months ago

I don't understand why this breaks the rust-aws-nitro-enclaves-cose too

I think the breakage is the known issue we already have with rust-aws-nitro-enclaves-cose where we patched it in Fedora.

yes, but it wasn't showing up upstream before, I need to take a look to check how we can avoid this upstream too, otherwise our tests and builds are all broken

I think I can add a commit to this PR that will mitigate it

nullr0ute commented 7 months ago

I don't understand why this breaks the rust-aws-nitro-enclaves-cose too

I think the breakage is the known issue we already have with rust-aws-nitro-enclaves-cose where we patched it in Fedora.

yes, but it wasn't showing up upstream before, I need to take a look to check how we can avoid this upstream too, otherwise our tests and builds are all broken

I think I can add a commit to this PR that will mitigate it

New commit fixes it