fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
59 stars 33 forks source link

fix(data-formats): use serde_tuple serializer for error messages #629

Closed mmartinv closed 7 months ago

mmartinv commented 7 months ago

Use serde_tuple to serialize/deserialize the error messages as a CBOR arrays instead of a CBOR maps as described in the FIDO Device Onboard Specification.

Fixes: #620

Signed-off-by: Miguel Martín mmartinv@redhat.com

7flying commented 7 months ago

Can we add some integration tests to check that the ErrorMessage structs are indeed serialised as arrays instead of maps?

7flying commented 7 months ago

I've merged this one manually since mergify did not kick in