search

fdocr / martilla

Easy to configure DB backup tool for simple everyday use on UNIX based systems
https://visualcosita.com/martilla-tool-for-db-backups/
MIT License
10 stars 4 forks source link

[Critical] Retency removes other files from s3 bucket #18

Closed Glorf closed 4 years ago

Glorf commented 4 years ago

Hi martilla, this last one is important, maybe even critical

I've been using one bucket, holding different backups of my services split into separate folders. When I put the backup into the bucket martilla just counted the objects in the bucket and removed the oldest one This is totally not acceptable and I was lucky that the file removed by the service was not important. Please, either fix the issue or put this in bold in your documentation that you need separate s3 bucket for every service that is being backed up by martilla

fdocr commented 4 years ago

Indeed a big issue, I'll take a look into it. Thanks a lot for the report!

fdocr commented 4 years ago

Hey @Glorf! Just in case you're interested in taking another look I just made available a release candidate with a fix for this problem (trying to avoid releasing more versions unless I'm confident the issue is properly fixed).

If you have some spare time I would inmensely appreciate if you can take a quick look at it, to make sure if you can't still reproduce the issue. The version to install is 0.4.0.rc

Glorf commented 4 years ago

Thanks @fdoxyz, I'll update soon

fdocr commented 4 years ago

Hi @Glorf, I actually just released v0.4.0 after adding more tests. I believe it should be working as expected, but of course let me know if you find any other problems :)