search

fdopen / ctypes-zarith

Demo how to mix ctypes and "custom" OCaml types
Other
4 stars 5 forks source link

adding support for mpq #1

Closed disteph closed 4 years ago

disteph commented 4 years ago

I had tested your code and it worked beautifully; I just needed to handle mpq as well as mpz. I tried to imitate what you did, and I added some tests. It seems to work. I created two Ocaml modules MPZ and MPQ and mildly changed some value names, but I'm happy if you want different naming conventions. Side-question: what do we do with this code? Shall we leave it as stand-alone, adding a licence, and make it available through opam?

fdopen commented 4 years ago

Thanks, looks good. I've cherry-picked your commit manually from the command line (384f390e93de1aa9fd4e65bf9ee2b311a9278f2a) and added a LICENSE file . If it simplifies you workflow, I can make it available at opam later.

disteph commented 4 years ago

Thanks! Yes, it's be great to have it on opam!

fdopen commented 4 years ago

It's now available in opam: https://github.com/ocaml/opam-repository/commit/9298ed54c3da7ca9352164eefe6e2c6616731313

disteph commented 4 years ago

Thanks!