Stop Patching in Broken Image-Base Behavior in Flexdll

fdopen / opam-repository-mingw

windows package repository for OPAM (mingw and msvc)

https://fdopen.github.io/opam-repository-mingw/

Creative Commons Zero v1.0 Universal

96 stars 33 forks source link

Stop Patching in Broken Image-Base Behavior in Flexdll #106

Open EmmaJaneBonestell opened 2 years ago

EmmaJaneBonestell commented 2 years ago

Since September of 2020, flexdll no longer passes image-base because it will create DLLs/plugins with relocations too far to be loaded.

https://github.com/alainfrisch/flexdll/issues/50 https://github.com/alainfrisch/flexdll/pull/89 https://github.com/ocaml/ocaml/pull/10351

OCaml versions 4.12.1 and newer need to stop passing this flag, but the inline-flexdll.patch is outdated and still implements this behavior on new versions of OCaml.

fdopen commented 2 years ago

The problem with the new solution is that it requires changes to external stub code. When the new OCaml version appeared, of course, no one had adapted the source code yet. I left the hack so that everything wouldn't stop working all at once. But you are right. Meanwhile some time has passed, I will release OCaml 4.14/flexlink 0.40 without it.