search

fdopen / opam-repository-mingw

windows package repository for OPAM (mingw and msvc)
https://fdopen.github.io/opam-repository-mingw/
Creative Commons Zero v1.0 Universal
96 stars 33 forks source link

Support for camlidl 1.06 #51

Closed yakobowski closed 5 years ago

yakobowski commented 5 years ago

As far as I can tell, a MinGW build of Camlidl has always been possible. Still, since I cannot easily check this, I only updated a new package for Camlidl 1.06, which has been released in the meantime.

I did not use the package description for Camlidl 1.05, in particular the camlidl-1.05.patch. It seemed simpler to use the Makefile.unix template instead, as it almost works. A PR has been opened for patch-so.diff at https://github.com/xavierleroy/camlidl/pull/10.

fdopen commented 5 years ago

What's cfactory.cpp? When it is necessary? It's not longer build (and it is incompatible to the latest OCaml runtime).

yakobowski commented 5 years ago

I have honestly no idea. By using Makefile.unix, it does no longer get built. It is only referenced in Makefile.win32.

fdopen commented 5 years ago

There are further windows specific files that you don't compile any longer: registry.cpp dispatch.c oletypes.c supererror.cpp, And these files are normally included into libcamlidl.a. I've therefore pushed your package, but with the original patch and an additional patch for OCaml 4.06+: https://github.com/fdopen/opam-repository-mingw/commit/b2f33775cc52ba362d566552c843b1ef09465edd Let me know, if it worked as intended.

yakobowski commented 5 years ago

Thanks, much appreciated. I will test tomorrow and report.

yakobowski commented 5 years ago

Thanks a lot, it worked flawlessly. I was able to (re)compile mlgmpidl and Apron using this package.