search

fdopen / opam-repository-mingw

windows package repository for OPAM (mingw and msvc)
https://fdopen.github.io/opam-repository-mingw/
Creative Commons Zero v1.0 Universal
96 stars 34 forks source link

Compiler newer version of GTKsourceview from sources #79

Closed MSoegtropIMC closed 2 years ago

MSoegtropIMC commented 4 years ago

This PR has two changes:

The latest version of gtksourceview for MinGW from Cygwin is 3.24.6-1 which is severely broken (it deletes important data structures whenever a thread ends which will crash all remaining threads after a while). This patch compiles a fixed version (3.24.11) from sources.

I am working on getting both fixed on Cygwin side, but it might take a while.

MSoegtropIMC commented 4 years ago

P.S.: I plan to create an updated cygwin package but currently don't have the bandwidth for it. The cygwin package currently does not have a maintainer - that's the reason it is old.

MSoegtropIMC commented 4 years ago

@fdopen : do you have any objections against this PR? This is well tested since about one year in the Coq distribution.

fdopen commented 4 years ago

I don't like it.

MSoegtropIMC commented 4 years ago

It only works, because the sandbox feature isn't implemented on Windows.

The opam file has

available: os = "win32" & os-distribution = "cygwinports"

because on each other system I am aware of this has been fixed quite a while (2 years ?) ago. Right now any application using this crashes after a while - not a nice feature for a source code editor (that's what gtksourceview is good for). Since this is only temporarily until a cygwin update is available, I would say the short comings are OK (except for the arch thing - an artifact from my build environment). I plan to make a new package for cygwin - it might take 2 or 3 months from now, though. The package currently does not have a maintainer in cygwin, so it likely won't happen unless one of us does it.

It doesn't work all the time (access rights,...).

IMHO a build error in (I believe) rather rare cases like Admin installed cygwin with user installing packages via opam is still better than nasty crashes of every GTK based text editor (the bug is in DLL main so one cannot get around it).

the %{arch}% usage is wrong

Sorry, an artifact from my build environment which slipped my merge review. What would be the correct usage?

What you should take from this PR is the information that gtksoureview3 is badly broken in your repo until it is fixed in some way. I honestly don't care how it is fixed, but I cannot work with a text editor which crashes every now and again.