Multiple Find and Replace results panels and the show next/previous result

[gene-pavlovsky]

Not sure if it's a bug or just a improvement suggestion, but bear with me :)

• Do Find&Replace with some search term, producing multiple result
• Check the "Keep Results" button in the results panel
• Use ShowNextResult shortcut - it works, opens a result from that panel
• Now do Find&Replace with a different search term, another results panel opens
• Use ShowNextResult shortcut - it works, opens a result from the new panel
• Close the second results panel
• Use ShowNextResult shortcut - nothing happens

Desired result: if a results panel is closed, give "focus" (in the sense of ShowNextResult etc.) to another existing results panel. The case is pretty simple if there is only one results panel remaining, if there are multiple "keep results" panels, the logic could be one of: select right-most panel (most recent F&R search), select most-recently-used panel, or do nothing in this case.

Realistic use case: I'm refactoring all use cases of some function call. I search for invocations of this function in all files, and mark the panel as "keep results". I pick a result, in the process of refactoring that file I need to check where this class is used (I now need to supply a dependency to it), I search for this class name in all files using F&R. I finish working on this case, and close the second F&R panel. I now want to go to the next case, I'd like to just hit the show next result hotkey and go to the next item in my (one) results panel.

[Neverbirth]

C'mon! Be glad you now have multiple panels! :P.

I would consider this more as an enhancement than a bug.

[gene-pavlovsky]

I'm glad and yes I think this is an RFE (request for enhancement). On further thought, it would be neat to have a "Refresh" button next to "Keep Results" - repeating the same search and updating the results in the same panel.

[Neverbirth]

Adding a "Refresh" button may be problematic, as this is a generic solution and this sounds quite specific to "Find" logic but we can talk more about it tomorrow.

[gene-pavlovsky]

What if the panel also accepts an optional "refresh" function together with results. If a sender (F&R dialog in this case) passes that refresh function, then the dialog will display the Refresh button that calls that function.