search

fdorg / flashdevelop

FlashDevelop is a free and open source code editor.
MIT License
829 stars 222 forks source link

Use Scintilla for the Output panel control #938

Open gene-pavlovsky opened 9 years ago

gene-pavlovsky commented 9 years ago

While using output panel's search box and the clear search text button, I've noticed two bugs. The panel was docked to prevent auto-hide.

  1. Just type some nonsense in the search box then click the clear search text button, click the search box again. Sometimes, the Search... invitation doesn't disappear, I can type right after it. The problem doesn't happen every time, not sure what are the conditions, sometimes it happens on first try.
    search-invitation
  2. Type some nonsense (e.g. something that can't be found in the output), then click the clear the search text button. Sometimes, the whole output gets selected. Doesn't happen every time, but it was pretty easy to reproduce. The problem also happens when searching for something that can be found, just not the whole output gets selected (e.g. I searched for Run, it was found, cleared the search, "Run" got highlighted with bright colors / not the same as used for search results normally). wrong-highlight

PS White on blue (highlight/highlight-text) is not how the actual search matches look (unchanged background and dim blue background)

Meychi commented 9 years ago

Issue 1 should be now fixed. 2 is down to buggy behaviour of the control, we need to change the control to Scintilla.

gene-pavlovsky commented 9 years ago

Looks like I can't reproduce #1 any more, great!