search

fdrmrc / Polydeal

C++ implementation of Polygonal Discontinuous Galerkin method within the deal.II Finite Element library.
https://fdrmrc.github.io/Polydeal/
Other
0 stars 0 forks source link

Iterators and Accessors classes #68

Closed fdrmrc closed 7 months ago

fdrmrc commented 11 months ago

While the current status works, there is a major design aspect which has to be considered.

We should not let the user know explicitely that only one deal.II cell (the "master" one) of an agglomerate carries the DoFs. In our assembly routines, we effectively loop through all the master cells (i.e. all the polygons), but they are by all means simple deal.II cells. This continuous identification between polyongs and master cells is certainly confusing from a user's perspective.

The cleanest solution would be to design an Accessors and Iterators classes in the spirit of the Particles namespace from deal.II (https://www.dealii.org/current/doxygen/deal.II/namespaceParticles.html).

fdrmrc commented 10 months ago

The sequence of PRs above, together with the refactoring in #78, mostly addressed the issue. I'll keep this issue open until the distributed case is handled

fdrmrc commented 7 months ago

This can be closed now.