fdschmidt93 / telescope-egrepify.nvim

Variable user customization for telescope.live_grep to set rg flags on-the-fly
MIT License
122 stars 13 forks source link

Does not support `sorting_strategy="descending"` #10

Closed otavioschwanck closed 1 year ago

otavioschwanck commented 1 year ago

image

Handbook has no items, the first item (top from bottom) has no title.

fdschmidt93 commented 1 year ago

I unfortunately do not run into this issue and spontaneously cannot think of as to why this occurs.

Happy to offer more support with more information, like minimal_init.lua and reproduction steps.

See also https://github.com/fdschmidt93/telescope-egrepify.nvim#disclaimer

otavioschwanck commented 1 year ago

I unfortunately do not run into this issue and spontaneously cannot think of as to why this occurs.

Happy to offer more support with more information, like minimal_init.lua and reproduction steps.

See also https://github.com/fdschmidt93/telescope-egrepify.nvim#disclaimer

nvim version: NVIM v0.9.2 Build type: Release LuaJIT 2.1.0-beta3

Mac.

Minimal:

-------------------------------------------------------------------------------
-- Options
-------------------------------------------------------------------------------
vim.opt.number = true
vim.opt.cursorline = true
vim.opt.smartindent = true
vim.opt.expandtab = true
vim.opt.tabstop = 4
vim.opt.shiftwidth = 4
vim.opt.laststatus = 3
vim.opt.cmdheight = 0
vim.opt.numberwidth = 4
vim.opt.signcolumn = "yes"

-------------------------------------------------------------------------------
-- Keymap
-------------------------------------------------------------------------------
-------------------------------------------------------------------------------
-- Bootstrap Package Manager
-------------------------------------------------------------------------------
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
    print("Installing 'folke/lazy.nvim'...")
    vim.fn.system({ "git", "clone", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.rtp:prepend(lazypath)

-------------------------------------------------------------------------------
-- Plugins
-------------------------------------------------------------------------------
require("lazy").setup({
    {
        "nvim-telescope/telescope-fzf-native.nvim",
        build = "cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=Release && cmake --build build --config Release && cmake --install build --prefix build",
    },
    {
        "fdschmidt93/telescope-egrepify.nvim",
        keys = {
            { "<C-p>", "<CMD>Telescope egrepify<CR>", mode = { "n", "i", "v" } },
        },
    },
    {
        "nvim-telescope/telescope.nvim",
        dependencies = "nvim-lua/plenary.nvim",
        config = function()
            require("telescope").setup({
                extensions = {

                    fzf = {
                        fuzzy = true,
                        override_generic_sorter = true,
                        override_file_sorter = true,
                    },
                },
            })

            require("telescope").load_extension("egrepify")
            require("telescope").load_extension("fzf")
        end,
    },
})
fdschmidt93 commented 1 year ago

Thanks!

I guess I see what happens, the rendering is essentially upside down.

The items are not missing, but rather above then below titles.

fdschmidt93 commented 1 year ago

Not sure when I'd get around to fix this, because it doesn't affect me (and again, referring to disclaimer as per README).

This actually might be surprisingly annoying, since the "title" gets always send first (and for now, always rendered first). The entry_maker now would have to cache the title until another title is shown. This may or may not be easy, begs the question how to ensure the final title is shown correctly though (albeit that hardly matters).

otavioschwanck commented 1 year ago

Not sure when I'd get around to fix this, because it doesn't affect me (and again, referring to disclaimer as per README).

This actually might be surprisingly annoying, since the "title" gets always send first (and for now, always rendered first). The entry_maker now would have to cache the title until another title is shown. This may or may not be easy, begs the question how to ensure the final title is shown correctly though (albeit that hardly matters).

is not just revert the list at the end?

And then, you could add a option: prompt_position = "top". something like that

fdschmidt93 commented 1 year ago

No, entry maker updates streaming input live. Simple reverting entries may or may not work, but is very hacky and not really any more simpler than a robust solution in practice.

I'd kindly ask you to please refrain from low-effort comments. This is an open source project I offer at best effort, which I have been very transparent about. If this is something you'd want to see fixed soon, I'd encourage you to work towards a fix.

otavioschwanck commented 1 year ago

Owner

i will switch the prompt position to top to work with this extension for now. Leave this issue open, at the weekend i will try to implement, ok?