search

fdschmidt93 / telescope-egrepify.nvim

Variable user customization for telescope.live_grep to set rg flags on-the-fly
MIT License
122 stars 13 forks source link

fix(preview): slightly defer skipping header for correct preview #43

Closed fdschmidt93 closed 1 month ago

fdschmidt93 commented 4 months ago

Fix #42

@mrbeardad could you please confirm this fixes your issue? :)

mrbeardad commented 4 months ago

@fdschmidt93 It is improved, but still exist.

megalithic commented 4 months ago

Initial usage of this branch looks to fix it for me (again, initial usage, will continue with this branch through out the day and report back). thanks for filing this @mrbeardad and thanks for the plugin and fixes, @fdschmidt93!

mrbeardad commented 3 months ago

It works good in mini init.lua, but not after install lots of plugins that make my nvim slow.

fdschmidt93 commented 3 months ago

I'm afraid this is a mega stupid bug. The solution now is also quite hacky, but anything else didn't seem to always work or would be significantly more complicated.

Please confirm this resolves this issue fully on your end :)

mrbeardad commented 3 months ago

@fdschmidt93 I'm sorry for the late reply. The issue about the wrong preview position is gone, but there is another bug that does not appear in master, to reproduce it:

  1. type <space>/ to open egrepify
  2. type a to search something
  3. type <c-p> to select previous item
  4. ui freezed until type <c-c> to interrupt (expect to select the last item)
fdschmidt93 commented 3 months ago

Thanks for reporting! Haven't tried reproducing but can very well imagine that this happens.

I'm afraid I most likely will only be able to be getting back to this some time in August. My apologies.

mrbeardad commented 3 months ago

Thanks for your working on this :)

evkorotkov commented 1 month ago

@fdschmidt93 @mrbeardad I fixed this problem in a slightly different way for myself could you take a look, does it make sense.. https://github.com/fdschmidt93/telescope-egrepify.nvim/pull/48

fdschmidt93 commented 1 month ago

Closing this as superseded by #48

Thank you @evkorotkov!