search

fdw / rofi-rbw

Rofi frontend for Bitwarden
https://github.com/fdw/rofi-rbw/
MIT License
192 stars 25 forks source link

Minor Credentials refactors #58

Closed tosti007 closed 2 years ago

tosti007 commented 2 years ago

This PR moves some wrapper functions and removes function arguments in order to reduce the logic in rofi_rbw.py a bit.

fdw commented 2 years ago

Hey! As is expected for a refactoring, there are some changes I like and some that I don't (sorry). Most importantly, you inspired me to try and restructure Entry and Credentials a bit 🙂 But how should we proceed here? Should I work on your branch, adding my changes? Do you want to rework it so we can merge it before I add my refactorings? Or should I do everything in separate commits and list you as co-author?

tosti007 commented 2 years ago

Haha no worries, these are mostly some changes that i thought might be nice. I'd say do whatever is easiest for you! If your idea is substantially different from mine I think creating your own commits would be easier than continuing on this branch, but if you prefer to continue with this PR feel free to do so.

fdw commented 2 years ago

I've just pushed something... it escalated a bit, but I like the structure a lot more now. What do you think?

tosti007 commented 2 years ago

Haha I think the reworks are great so I'll close this