search

fdw / rofimoji

Emoji, unicode and general character picker for rofi and rofi-likes
https://github.com/fdw/rofimoji
MIT License
841 stars 48 forks source link

Nerd Font extractor: Omit "removed" (deprecated) icons #198

Open reeseovine opened 1 week ago

reeseovine commented 1 week ago

According to https://www.nerdfonts.com/cheat-sheet:

With Release v3.0.0 the Material Design Icons were updated and moved to new codepoints (reasons for that are in the release notes). They are still shown here for reference, but are missing in the actual fonts. To find for example the replacement for nf-mdi-altimeter enter just altimeter in the search box.

Since these nf-mdi-* icons are still included, there are a whole bunch of results with wrong/missing characters.

image

One possible solution I can think of would be to modify the bs4 query to look for and omit .column elements with a .corner-red inside.

image

fdw commented 1 week ago

Huh, thanks, I never noticed. Are you interested in writing a PR for that?

reeseovine commented 1 week ago

Sure! I did attempt it once already but:

  1. How am I meant to run the extractors when developing? After fetching the poetry deps, running poetry run python src/extractors/ tells me ImportError: attempted relative import with no known parent package. My python version is 3.11.9.
  2. I'm not sure what the best / most efficient way is to go about filtering elements from a selection, but I'll figure that out once I get past (1)

Basically, I have a bad memory and I don't at all remember how I contributed to this repo before (which github says I have), so a little direction would be very much appreciated <3

fdw commented 1 day ago

Sorry I didn't get back to you sooner, life got in the way...

While updating to Unicode 16, I noticed that the old NerdFont extractor didn't work at all anymore, and so I fixed it 😉 I think/hope that also fixes this issue, but please check and report back.