fdw / rofimoji

Emoji, unicode and general character picker for rofi and rofi-likes
https://github.com/fdw/rofimoji
MIT License
859 stars 48 forks source link

Feature Request: Change color of character when `--use-icons` used #201

Closed psynyde closed 6 days ago

psynyde commented 1 month ago

as the title suggests is there any possibility to change font color with icons as they're tough to see when using dark theme for example. image

fdw commented 1 month ago

Have you tried a different theme or setting it the font color explicitly?

psynyde commented 1 month ago

Have you tried a different theme or setting it the font color explicitly?

1st of all, Sorry for a quite late reply.

image

this is the rasi code i'm using to replicate the image above.

configuration {
     show-icons: true;
}
 textbox {
     vertical-align: 0.5;
     horizontal-align: 0.5;
}
 listview {
     columns: 7;
     lines: 9;
     cycle: false;
     dynamic: false;
     layout: vertical;
     flow: horizontal;
     reverse: false;
     fixed-height: true;
     fixed-columns: true;
}
 element {
     orientation: vertical;
     padding: 3px;
     text-color: #f0f0f0;
}
 element selected.normal {
     background-color: #202020;
     border-radius: 5px;
}
 element-icon {
     background-color: transparent;
     text-color: #f0f0f0;
     size: 24px;
     vertical-align: 0.5;
     horizontal-align: 0.5;
}
 element-text {
     enabled: false;
     text-color: #f0f0f0;
}

as you can see i've used text-color on every element related classes but still the font color is black.

my assumtion is you need to add text-color properties in this span tag but idk if it's possible as rofi doesn't follow usual css/html rules afaik

fdw commented 1 month ago

I see, thanks. I could probably add something to the span tag, but I'm very hesitant: It must be configurable, but it shouldn't be a parameter to rofimoji.

I think the best solution would be for rofi to support the icon color in themes. And there is apparently already an issue for it: https://github.com/davatorium/rofi/issues/2026

fdw commented 6 days ago

If you don't mind, I'd close this issue until upstream supports this.