search

fearfm / website

Public website
1 stars 2 forks source link

Audioplayer does not show buffer status #37

Closed pimjansen closed 3 years ago

pimjansen commented 3 years ago

The audio player should show a buffer status when its buffering. My suggestion would be to show a spinning thing where we hold the play/pause button as well.

vanderSangen88 commented 3 years ago

Needs to be tested if it's working as it should be; the onBuffer- & onPlay-callbackProps of the ReactPlayer-component.

Based on current docs/issues in https://github.com/CookPete/react-player, no option is available yet to get the progress of the buffering. Would have been nice to show as value inside the MUI CircularProgress-component.

pimjansen commented 3 years ago

I suggest we close this for now since atleast we show an indication that the buffering is busy though. We can always improve at the end