fearless359 / simpleinvoices

Fearless359 SimpleInvoices beyond great beginnings
https://simpleinvoices.group
GNU General Public License v3.0
28 stars 7 forks source link

Payments display sort stuck on Payment type #18

Closed johnanastasio17 closed 7 years ago

johnanastasio17 commented 7 years ago

When viewing Payments screen, payments are listed A-Z by type (cash, then check, then electronic, etc). Can not change column sort to "by date", "by number", "by customer", etc. Can not reverse any of the columns (including payment type that it is stuck on) from A-Z to Z-A Columns are fully sortable when accessing database in phpMyadmin. No errors when entering a new payment, data is writing to database. I do notice that the first payment recorded since switching from si2011 to fearless359 version has NULL under "online_payment_id" column, no previous entries have this. Using Fearless359/simpleinvoices, on Wampserver64, Win10 64bit Same behavior with Firefox and Chrome

tmtisfree commented 7 years ago

This is because column names are improperly referenced in $validFields array in the 'xml.php' file and in flexigrid in the 'manage.js.php' file, in the payment module.

Open both 'modules/payments/manage.js.php' and 'modules/payments/xml.php' files.

In 'manage.js.php', replace the 'biller' string with the string 'bname', and replace the 'customer' string with the string 'cname'. Save.

In 'xml.php', search for the '$validFields' array. Replace the 'biller' string with the string 'bname', and replace the 'customer' string with the string 'cname'. Save.

Reload (beware to also edit the payment_quickview extension if you happen to use it, as it has the same files with the same problem).

Both columns are now sortable.

fearless359 commented 7 years ago

Just upload fix for column sort on payments and invoices flex grid. This includes grids when payments extension is enabled.