feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.48k stars 978 forks source link

move dependency and virtual env management to poetry #3875

Closed robhowley closed 7 months ago

robhowley commented 8 months ago

Is your feature request related to a problem? Please describe. Manage python dependencies via poetry for simpler builds and virtual env management.

Describe the solution you'd like Would like to see poetry configs added to the existing pyproject.toml and a poetry.lock committed to the project.

Describe alternatives you've considered Stick with current setup.py

Additional context The affirm/feast fork implemented this and can be used as inspiration. Looks like @franciscojavierarceo and @hao-affirm did so here.

sudohainguyen commented 7 months ago

although a fan of poetry but I don't think if there is a significant impact adopting poetry, would cause unnecessary complexity, especially when connecting between setup.py and poetry.lock 🤔