feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.3k stars 940 forks source link

Multicloud Dockerfile uses latest published version of Feast instead of version under testing #4135

Open jeremyary opened 3 weeks ago

jeremyary commented 3 weeks ago

Expected Behavior

Dockerfiles within GitHub Actions should utilize the latest/pending version of library instead of using latest/previous. This PR describes the original issue:

feature_servers/multicloud does not use master sources to install feast in image. It uses pypi's feast latest version. Even though the github publish action has a needs on publish-python-sdk before running the publish step, pypi cache might not be updated causing an older feast sdk version to be installed.

This PR reverted the change - our builds began breaking due to a race condition wherein the Dockerfile expected the pending version of library to be available based on needs conditional associated to the Action, however, the action failed as either the sequential dependency isn't respected or something else is leading the Dockerfile to poll external repositories for the library version and failing in cases where the pending code version isn't yet published.

Current Behavior

Dockerfile is using latest published version as opposed to pending version - see original PR for more.

Steps to reproduce

Specifications

Possible Solution

jeremyary commented 3 weeks ago

cc @bushwhackr