feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.55k stars 993 forks source link

Rewrite StreamFeatureView to extend BaseFeatureView instead of FeatureView #4398

Open tokoko opened 2 months ago

tokoko commented 2 months ago

Feature Views in feast have inconsistent class hierarchy where OnDemandFeatureView extends BaseFeatureView base class, while StreamFeatureView extends FeatureView. This complicates type checking across the code base. This should be changed to make all user-facing FV classes (FeatureView, StreamFeatureView, OnDemandFeatureView and BatchFeatureView) leaves in the hierarchy.

franciscojavierarceo commented 2 months ago

Agree.