feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.57k stars 996 forks source link

Feast create empty online table when FeatureView attribute online=False #4616

Open SuperBo opened 2 weeks ago

SuperBo commented 2 weeks ago

Expected Behavior

Feast shouldn't create any DynamoDB table when I defined FeatureView with online=False.

Current Behavior

Feast creates empty DynamoDB table when I defined FeatureView with online=False.

Steps to reproduce

Define a feature store like this

project: example_feature_sotre

provider: aws

offline_store:
  type: spark
  spark_conf: {}

online_store:
  type: dynamodb
  region: us-east-1

entity_key_serialization_version: 2

Feature view def

feature_view = FeatureView(
    name="abc_details_monthly",
    entities=[user_id],
    online=False,
    source=SparkSource(
      table="shcema.abc_details_monthly",
      name="abc_details_monthly",
      timestamp_field="event_date",,
      ttl=datetime.timedelta(days=27),
    # Schema definition
    schema=[
        Field(
            name="feature_1_1d",
            dtype=types.Int32,
            description=""
        )
    ]
)

Specifications

Possible Solution

Should distinguish list tables to keep of online store and offline store in this file.

https://github.com/feast-dev/feast/blob/cd87562df7f55dfe888bfbbd9a33b87670681040/sdk/python/feast/infra/passthrough_provider.py#L122

franciscojavierarceo commented 2 weeks ago

Yeah, agree wasted space.