Closed dandawg closed 4 weeks ago
FYI, all of these messages come from the Uvicorn web server that we use in the online server, like this. Anyway, I agree we should try to be consistent with the information displayed to the user.
@lokeshrangineni this can be closed based on your PR #4660
PR is merged so we can close this ticket.
Expected Behavior
The
feast serve_offline
command (which launches a feast offline server process) should behave similar to thefeast serve
command, which displays helpful information, including the serving endpoint (host:port). Thefeast serve
command shows info like the following:And on shutdown, the
feast serve
command gives:Note: this issue may affect the registry server as well. I have not looked into that, but my expectation would be that all three servers should have logging at startup, during operation, and at shutdown.
Current Behavior
The
feast serve_offline
command just launches the process and displays no output but a blinking cursor. The user is left wondering if the server is ready, and what endpoint it is running on. There is also presumably no information to capture for logging to show for example, when the server started or shutdown.Steps to reproduce
Specifications
Possible Solution
Add logging to
feast serve_offline
following the pattern offeast serve
.