feast-dev / feast

The Open Source Feature Store for Machine Learning

https://feast.dev

Apache License 2.0

5.62k stars 1k forks source link

perf: Make /push async #4650

Closed robhowley closed 1 month ago

robhowley commented 1 month ago

What this PR does / why we need it:

make the /push endpoint async
if pushing to online and async writes for the OnlineStore are supported, will call await store.push
offline writes in the async codepaths utilize run_in_threadpool
this pr only adds the calls and interface, there are no online stores that support async write
added tests for when async vs sync calls of store.push happen in the server

Which issue(s) this PR fixes:

Misc

HaoXuAI commented 1 month ago

good feature!