feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.62k stars 1k forks source link

feat: Update the go feature server from Expedia code repo. #4665

Open shuchu opened 1 month ago

shuchu commented 1 month ago

What this PR does / why we need it:

Update the improved Go feature server code from ExpediaGroup/Feast to our code repo.

Which issue(s) this PR fixes:

shuchu commented 1 month ago

cc: @EXPEbdodla

shuchu commented 1 month ago

[Update 10-22-2024] Now it can compile, build and build docker image. All configures in the Makefile under the "#Go SDK & embedded" are working, except the "install-go-ci-dependencies".

The current "install-go-ci-dependencies" is obsoleted. We need to fix it when we setup the integration test for Go feature server.

!!Warning, the current version my not function correctly. need more testing and investigating.

shuchu commented 3 weeks ago

[Update 10-31-2024]

  1. "make test-go" works now
  2. DataDog related observability instrumentation code were commented out but not removed. I keep these code and plan to use OTEL to replace them.
shuchu commented 3 weeks ago

[Update 11/04/2024]

  1. The HTTP Registry code is removed as it depends on an external HTTP server as @EXPEbdodla pointed out.
  2. The default Registry is File based one now.
shuchu commented 5 days ago

[Update 11-20-2024] 1, about the transformation service endpoint issue, I couldn't find a better solution now since this is a design choice between the "not working" callback function and using Python based transformation gRPC service. As for now, I use a general string to represent the endpoint. Sorry about this. I will spend more time to understand the code and see if we can do it in a better way. cc: @EXPEbdodla @tokoko @franciscojavierarceo

shuchu commented 1 day ago

[Update 11/24/2024]

  1. use the feature_store.yaml file as the source of defining Python transformation service. Example:
    # feature_store.yaml file
    feature_store:
    transformation_service_endpoint: "localhost:50051"

@EXPEbdodla @feast-dev/reviewers-and-approvers