Closed franciscojavierarceo closed 1 month ago
This is not gonna work unfortunately, OWNERS file is supposed to be read by prow, which I'm pretty sure is not longer active, not sure who was hosting it in the first place.
Wiping OWNERS file and updating CODEOWNERS to have reviewers too. I think that's a simple enough process for now?
We can have team members at Red Hat add prow support later but for now OWNERS is a distraction then.
just making sure.. CODEOWNERS just means the group will be requested a review if a PR touches any of those folders. It doesn't actually give any new permissions to either approve or merge.
I have that configured in the repo settings.
Oh.. okay. does that mean require a review from all code owners or at least one? We might be shooting ourselves in the foot if everyone needs to approve all PRs :laughing:
Nope! There's configuration to do round robin and only requiring one approver.
You only need one approver before merging.
can you approve? :D
What this PR does / why we need it:
Add Daniele and Lokesh as Approvers and Reviewers
Which issue(s) this PR fixes:
N/A
Misc