feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.62k stars 1k forks source link

chore: Add Daniele and Lokesh as Approvers and Reviewers #4672

Closed franciscojavierarceo closed 1 month ago

franciscojavierarceo commented 1 month ago

What this PR does / why we need it:

Add Daniele and Lokesh as Approvers and Reviewers

Which issue(s) this PR fixes:

N/A

Misc

tokoko commented 1 month ago

This is not gonna work unfortunately, OWNERS file is supposed to be read by prow, which I'm pretty sure is not longer active, not sure who was hosting it in the first place.

franciscojavierarceo commented 1 month ago

Wiping OWNERS file and updating CODEOWNERS to have reviewers too. I think that's a simple enough process for now?

We can have team members at Red Hat add prow support later but for now OWNERS is a distraction then.

tokoko commented 1 month ago

just making sure.. CODEOWNERS just means the group will be requested a review if a PR touches any of those folders. It doesn't actually give any new permissions to either approve or merge.

franciscojavierarceo commented 1 month ago

I have that configured in the repo settings.

Screenshot 2024-10-23 at 12 31 57 PM

tokoko commented 1 month ago

Oh.. okay. does that mean require a review from all code owners or at least one? We might be shooting ourselves in the foot if everyone needs to approve all PRs :laughing:

franciscojavierarceo commented 1 month ago

Nope! There's configuration to do round robin and only requiring one approver.

franciscojavierarceo commented 1 month ago

You only need one approver before merging.

franciscojavierarceo commented 1 month ago

can you approve? :D